Fix Enum#to_s for private enum #9126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enum#to_s no longer relies on constant lookup which would fail if the type is declared with private visibility.
straight-shoota
added
kind:bug
jhass
previously approved these changes
Apr 18, 2020
asterite
reviewed
Apr 18, 2020
asterite
previously requested changes
Apr 18, 2020
|
There are other places in enum.cr that uses |
waj
requested changes
Apr 18, 2020
jhass
reviewed
Apr 18, 2020
RX14
previously approved these changes
Apr 20, 2020
jhass
previously approved these changes
Apr 21, 2020
|
CI is red |
bcardiff
approved these changes
Apr 21, 2020
waj
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum#to_sno longer relies on constant lookup which would fail if the type is declared with private visibility.Resolves #9044