Add Path#each_part iterator #9138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice demo for why the compiler should support generating such iterators automatically, but also why it's so difficult. |
straight-shoota
force-pushed
the
feature/path-each-part-iterator
branch
from
473e665
to
27d8862
Compare
straight-shoota
force-pushed
the
feature/path-each-part-iterator
branch
from
27d8862
to
82a4c64
Compare
|
@crystal-lang/crystallers Would be great to get reviews on this because I have a follow-up waiting =) |
RX14
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new overload of
Path#each_partthat returns an iterator.