XML: improve xpath regarding namespaces #9288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9279
I checked Nokogiri and if you do this:
It works out of the box. My guess is that it passes the root namespaces of the document so they can be found with the registered prefixes. So in this PR I do the same.
I also
lchop
the "xmlns:" prefix of namespaces when registering them. Again, checking what Nokogiri does, the namespaces are returned with the "xmlns:" prefix, but that needs to be removed when registering namespaces for the xpath lookup.