Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor INI improvements #9408

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Jun 2, 2020

Minor improvement to the INI class, which is more a module in fact.
Changed str to string_or_io, which is also used in lots of other methods accepting a String or IO like .from_json and .from_yaml, JSON::Parser.new, CSV.parse etc...

j8r added 2 commits June 1, 2020 19:27
INI is more a module, having no constructor.
@bcardiff
Copy link
Member

bcardiff commented Jun 2, 2020

Ok, it's aligned with other formats been a module and not a class.

Let it be the last breaking-change until 1.0. 🤞

@bcardiff bcardiff added this to the 0.35.0 milestone Jun 2, 2020
@bcardiff bcardiff merged commit ea9d9b1 into crystal-lang:master Jun 3, 2020
@j8r j8r deleted the minor-ini-improvements branch June 3, 2020 16:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants