Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add % method to BigDecimal #9784

Closed
wants to merge 6 commits into from
Closed

Fix: add % method to BigDecimal #9784

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
364cd49
Fix: add % method to BigDecimal
Sep 30, 2020
8d06816
Add spec for BigDecimal#%
Oct 1, 2020
4210e08
A few more specs for BigDecimal#%
Oct 1, 2020
7277248
re-add spec
Oct 9, 2020
3022c83
make ci happy *sigh*
Oct 13, 2020
ca391dd
Merge branch 'master' into master
straight-shoota Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions spec/std/big/big_decimal_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ describe BigDecimal do
BigDecimal.new(3333.to_big_i, 7_u64).should eq(BigDecimal.new(1).div(BigDecimal.new(3000), 7))

(-BigDecimal.new(3)).should eq(BigDecimal.new(-3))

(BigDecimal.new(5) % BigDecimal.new(2)).should eq(BigDecimal.new(1))
(BigDecimal.new(500) % BigDecimal.new(2)).should eq(BigDecimal.new(0))
(BigDecimal.new(500) % BigDecimal.new(2000)).should eq(BigDecimal.new(500))
end

it "performs arithmetic with other number types" do
Expand Down Expand Up @@ -383,6 +387,17 @@ describe BigDecimal do
bd6.to_f!.should eq -1.1
end

it "handles modulus correctly" do
(BigDecimal.new(13.0) % BigDecimal.new(4.0)).should eq(BigDecimal.new(1.0))
(BigDecimal.new(13.0) % BigDecimal.new(-4.0)).should eq(BigDecimal.new(-3.0))
(BigDecimal.new(-13.0) % BigDecimal.new(4.0)).should eq(BigDecimal.new(3.0))
(BigDecimal.new(-13.0) % BigDecimal.new(-4.0)).should eq(BigDecimal.new(-1.0))
(BigDecimal.new(11.5) % BigDecimal.new(4.0)).should eq(BigDecimal.new(3.5))
(BigDecimal.new(11.5) % BigDecimal.new(-4.0)).should eq(BigDecimal.new(-0.5))
(BigDecimal.new(-11.5) % BigDecimal.new(4.0)).should eq(BigDecimal.new(0.5))
(BigDecimal.new(-11.5) % BigDecimal.new(-4.0)).should eq(BigDecimal.new(-3.5))
end

it "hashes" do
bd1 = BigDecimal.new("123.456")
bd2 = BigDecimal.new("0.12345")
Expand Down
16 changes: 16 additions & 0 deletions src/big/big_decimal.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,22 @@ struct BigDecimal < Number
self * BigDecimal.new(other)
end

def %(other : BigDecimal) : BigDecimal
if @scale > other.scale
scaled = other.scale_to(self)
BigDecimal.new(@value % scaled.value, @scale)
elsif @scale < other.scale
scaled = scale_to(other)
BigDecimal.new(scaled.value % other.value, other.scale)
else
BigDecimal.new(@value % other.value, @scale)
end
end

def %(other : Int)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same overload could be added for Float perhaps?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll add that. Thanks!

self % BigDecimal.new(other)
end

def /(other : BigDecimal) : BigDecimal
div other
end
Expand Down