-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to libpcre2 #219
Merged
Merged
Update to libpcre2 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
beta-ziliani
approved these changes
Feb 10, 2023
@straight-shoota I'm certain I didn't break anything with my merge commit, but please double check before merging. Thanks mate! |
Oh, I'm pretty sure you did. The merge commit picks the |
beta-ziliani
approved these changes
Feb 13, 2023
This was referenced Feb 14, 2023
beta-ziliani
approved these changes
Feb 16, 2023
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Feb 23, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb This includes the following changes: * Add --disable-cpp * Temporarily disable JIT * Update omnibus to PCRE2 * Update linux build to PCRE2 * crystal-lang/distribution-scripts#219)
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Feb 24, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb This includes the following changes: * Add --disable-cpp * Temporarily disable JIT * Update omnibus to PCRE2 * Update linux build to PCRE2 * crystal-lang/distribution-scripts#219)
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Feb 28, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@dd0ef75 This includes the following changes: * crystal-lang/distribution-scripts#224) * crystal-lang/distribution-scripts#219)
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Feb 28, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@dd0ef75 This includes the following changes: * crystal-lang/distribution-scripts#224) * crystal-lang/distribution-scripts#219)
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Feb 28, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb This includes the following changes: * Add --disable-cpp * Temporarily disable JIT * Update omnibus to PCRE2 * Update linux build to PCRE2 * crystal-lang/distribution-scripts#219)
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Feb 28, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb This includes the following changes: * Add --disable-cpp * Temporarily disable JIT * Update omnibus to PCRE2 * Update linux build to PCRE2 * crystal-lang/distribution-scripts#219)
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Mar 14, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@2d85f41 This includes the following changes: * crystal-lang/distribution-scripts#219 * crystal-lang/distribution-scripts#223 * crystal-lang/distribution-scripts#222 * crystal-lang/distribution-scripts#218 * crystal-lang/distribution-scripts#216 * crystal-lang/distribution-scripts#215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the effort to migrate the regex engine to PCRE2 (crystal-lang/crystal#12790).
With crystal-lang/crystal#12978, PCRE2 becomes the default engine at which point we should ship libpcre2 in the packages where we distribute the regex library.
That's the bundled tarball and the docker images.