Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libpcre2 #219

Merged
merged 9 commits into from
Feb 18, 2023
Merged

Update to libpcre2 #219

merged 9 commits into from
Feb 18, 2023

Conversation

straight-shoota
Copy link
Member

This is a part of the effort to migrate the regex engine to PCRE2 (crystal-lang/crystal#12790).

With crystal-lang/crystal#12978, PCRE2 becomes the default engine at which point we should ship libpcre2 in the packages where we distribute the regex library.
That's the bundled tarball and the docker images.

@straight-shoota straight-shoota marked this pull request as ready for review February 1, 2023 21:43
@straight-shoota straight-shoota self-assigned this Feb 7, 2023
@beta-ziliani
Copy link
Member

@straight-shoota I'm certain I didn't break anything with my merge commit, but please double check before merging. Thanks mate!

@straight-shoota
Copy link
Member Author

Oh, I'm pretty sure you did. The merge commit picks the COPY --from=libpcre line from master which breaks the docker build.

@straight-shoota straight-shoota merged commit 2d85f41 into master Feb 18, 2023
@straight-shoota straight-shoota deleted the feature/pcre2 branch February 18, 2023 09:21
straight-shoota added a commit to crystal-lang/crystal that referenced this pull request Feb 23, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb

This includes the following changes:

* Add --disable-cpp
* Temporarily disable JIT
* Update omnibus to PCRE2
* Update linux build to PCRE2
* crystal-lang/distribution-scripts#219)
straight-shoota added a commit to crystal-lang/crystal that referenced this pull request Feb 24, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb

This includes the following changes:

* Add --disable-cpp
* Temporarily disable JIT
* Update omnibus to PCRE2
* Update linux build to PCRE2
* crystal-lang/distribution-scripts#219)
straight-shoota added a commit to crystal-lang/crystal that referenced this pull request Feb 28, 2023
straight-shoota added a commit to crystal-lang/crystal that referenced this pull request Feb 28, 2023
straight-shoota added a commit to crystal-lang/crystal that referenced this pull request Feb 28, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb

This includes the following changes:

* Add --disable-cpp
* Temporarily disable JIT
* Update omnibus to PCRE2
* Update linux build to PCRE2
* crystal-lang/distribution-scripts#219)
straight-shoota added a commit to crystal-lang/crystal that referenced this pull request Feb 28, 2023
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@554b1cb

This includes the following changes:

* Add --disable-cpp
* Temporarily disable JIT
* Update omnibus to PCRE2
* Update linux build to PCRE2
* crystal-lang/distribution-scripts#219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants