Feature/warn only crystal version #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use crystal version to restrict the packages. Warn about packages that might not work for the current crystal version. Drop --ignore-crystal-version option
oprypin
reviewed
Apr 14, 2021
Sija
reviewed
Apr 14, 2021
Added TODO per suggestion of @Sija Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
src/cli.cr
Outdated
| @@ -44,7 +44,8 @@ module Shards | |||
| self.skip_postinstall = true | |||
| end | |||
| opts.on("--local", "Don't update remote repositories, use the local cache only.") { self.local = true } | |||
| opts.on("--ignore-crystal-version", "Do not enforce crystal version restrictions on shards.") { self.ignore_crystal_version = true } | |||
| # TODO: remove in the future | |||
| opts.on("--ignore-crystal-version", "Kept for compatibility, to be removed in the future.") { } | |||
There was a problem hiding this comment.
Suggested change
| opts.on("--ignore-crystal-version", "Kept for compatibility, to be removed in the future.") { } | |
| opts.on("--ignore-crystal-version", "Has no effect. Kept for compatibility, to be removed in the future.") { } |
|
It seems this needs a formatter run. |
Incorporating wording suggestions by @straight-shoota Co-authored-by: Johannes Müller <straightshoota@gmail.com>
|
I think we're good to go, once the CI passes let's merge this (pinging @straight-shoota) |
straight-shoota
approved these changes
Apr 17, 2021
|
Hello @beta-ziliani @bcardiff, possible a new release of shards with this change is made? Not asking packages of Crystal 1.0.1 to be released, but at least having shards updates so impacted folks can use or point users to that manual upgrade until a new distribution of Crystal is released. Thank you. |
|
(literally speaking, it should be possible, as mentioned here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the semantics of the
crystal:field to be a "maintainers claim it works in these versions of the compiler", warning in case the current version is not listed. An empty field means*, as coded in PR #493 by @oprypin.It is an implementation (by @bcardiff) of the proposal I made as a comment in PR #493.