Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add != operator for version resolve #520

Merged
merged 4 commits into from
Sep 20, 2021

Conversation

syeopite
Copy link
Contributor

Closes #519

@beta-ziliani
Copy link
Member

The test is failing because of the formatter. Let me know @syeopite if you want me to take care of it, or if you can fix it.

@syeopite
Copy link
Contributor Author

syeopite commented Aug 18, 2021

Ah thanks! I was wondering why CI failed

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI says so, I say this is ready to go. Thanks!

spec/unit/versions_spec.cr Outdated Show resolved Hide resolved
- Better check for resolve
- Errors caused by linting
@straight-shoota straight-shoota changed the title Add != operator for version resolve Add != operator for version resolve Sep 20, 2021
@straight-shoota straight-shoota merged commit 8f48d4e into crystal-lang:master Sep 20, 2021
@straight-shoota straight-shoota added this to the v0.16.0 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for != operator in Crystal version
4 participants