Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honour CRYSTAL env var #534

Merged

Conversation

straight-shoota
Copy link
Member

This is a reissue of #415 reduced to the original scope. It makes shards honour the CRYSTAL environment variable when calling the crystal program to determine the Crystal version and for shards build.

Resolves #406

Although it is not used. But that's the pattern followed in config.cr for now.
Avoid requiring crystal to be available in path.
This can allow wrapper scripts on shards and have a cleaner override of the CRYSTAL_VERSION to use to resolve dependencies.
@oprypin
Copy link
Member

oprypin commented Dec 8, 2021

Specs fail on Windows

@straight-shoota
Copy link
Member Author

Yeah, that was #532

@oprypin
Copy link
Member

oprypin commented Dec 8, 2021

Seems not ¯\_(ツ)_/¯

@straight-shoota
Copy link
Member Author

Yeah, now we get the actual failures on windows. Not the unrelated ones.

@Sija
Copy link
Contributor

Sija commented Dec 8, 2021

Windows doesn't like ${CRYSTAL:-crystal} within the command.

@straight-shoota straight-shoota added this to the v0.17.0 milestone Dec 13, 2021
@straight-shoota straight-shoota merged commit c89f866 into crystal-lang:master Dec 16, 2021
@straight-shoota straight-shoota deleted the feature/crystal-env-var branch December 16, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution of crystal dependency is hard tied to crystal executable
4 participants