No longer depend of external git user config #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Git-related tests required external configuration of email and name. This forced tweaks in CI and other environments to have those set globally before running tests. This change makes this self-contained: Git repositories created part of the test suite are going to automatically set a default email and name.
oprypin
reviewed
Dec 15, 2021
Use `git_path` helper instead of `Process.quote` as was incorrect in that context. Looking at other examples it appears to be the correct method to use, even when dealing with nested `Dir.cd` operations.
straight-shoota
approved these changes
Dec 16, 2021
oprypin
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Git-related tests required external configuration of email and name. This forced tweaks in CI and other environments to have those set globally before running tests.
This change makes this self-contained: Git repositories created part of the test suite are going to automatically set a default email and name.
Note: this might look silly, but removes the need to set that up when running the specs in a controlled container environment (and not a development one) and has no impact on existing CI or others running it.
Thank you.
❤️ ❤️ ❤️