Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expanded local path to shard.yml error message in PathResolver #541

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jan 21, 2022

This patch enhances the error information when a path resolver can't find shard.yml: It shows the expanded path of the directory where it looked for the file.

/cc #308, #309

@straight-shoota straight-shoota force-pushed the feature/enhance-error-path-no-shardyml branch 2 times, most recently from e95a914 to 3b5cec9 Compare January 21, 2022 15:46
@straight-shoota straight-shoota force-pushed the feature/enhance-error-path-no-shardyml branch from 3b5cec9 to ab1444b Compare January 21, 2022 15:48
@straight-shoota straight-shoota changed the title Add expanded local path to shard.yml error message in PathResolver Add expanded local path to shard.yml error message in PathResolver Jan 21, 2022
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@straight-shoota straight-shoota added this to the v0.17.0 milestone Mar 8, 2022
@straight-shoota straight-shoota merged commit f9f52ec into crystal-lang:master Mar 17, 2022
@straight-shoota straight-shoota deleted the feature/enhance-error-path-no-shardyml branch March 17, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants