Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Run git config instead of reading config file manually" #642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

straight-shoota
Copy link
Member

The change is broken on Windows. This was masked by the CI failure due to #640.

E: Failed git config --get-regexp 'remote..+.mirror'.

Reverts #639

@beta-ziliani
Copy link
Member

But why does that command fails? is that an issue with git?

@HertzDevil
Copy link
Contributor

I think it would work on Windows if the single quotation marks are dropped

@straight-shoota
Copy link
Member Author

It's documented behaviour of git config to exit with code 1 if "the section or key is invalid". Apparently --get-regexp considers a non-matching expression as an invalid key.

And the git behavious is not specific on Windows, it works the same on Linux (and I presume MacOS as well).
git config --get-regexp 'remote\..+\.mirror' on a repo with no matching remote in the config, exits with 1.

I just don't quite understand why this does not lead to a failure in shards on Linux and MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants