Install mercurial via OS package manager #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Oct 6, 2024
.github/workflows/ci.yml
Outdated
| @@ -36,6 +36,7 @@ jobs: | |||
|
|
|||
| - name: Install Mercurial | |||
| run: pip install mercurial | |||
| if: ${{ matrix.os != 'windows-2022' }} | |||
There was a problem hiding this comment.
Using startsWith might be more versatile.
There was a problem hiding this comment.
question (nonblocking): we don't need python and pip anymore on Windows, do we? In fact, why not always install fossil & mercurial from apt, homebrew or choco?
There was a problem hiding this comment.
Good point. Applied!
ysbaddaden
approved these changes
Oct 7, 2024
straight-shoota
changed the title
ysbaddaden
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing mercurial via pip on Windows fails due to a missing dependency. But the chocolatey package works, so let's use that.
Actually, let's use OS-specific package managers on all platforms to install mercurial (like we already do for fossil).
The spec suite still fails due to #639 (comment), but that's a different issue (#639). This patch makes it even work at all.
Resolves #640