This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Addition of crystal-core and crystal-branding #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axtloss
approved these changes
Oct 15, 2022
axtloss
reviewed
Oct 15, 2022
|
As said on Discord, we might want to wait for |
not-my-segfault
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Two new packages has been recently added to the Crystal's packages GitHub organisation, they will have to be installed during any Crystal installation.
ame,crystal-keyringandcrystal-mirrorlist. This was previously handled by our custombasepackage which has recently been dropped in favor of thiscrystal-corepackage./etc/issue,/etc/os-release) but also to set the "GRUB_DISTRIBUTOR" variable's value in/etc/default/grubifgrubis installed (but without actually depending ongrub).Therefore, it will have to be installed twice on systems that use
grub. Once as abasepackage and once aftergrubhas been installed in order to update the "GRUB_DISTRIBUTOR" variable's value in/etc/default/grub.Hopefully, this PR is correct 😅
Don't hesitate to ask for changes if needed 😄