Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating failing specs and dependencies to latest #40

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

jwoertink
Copy link
Contributor

@jwoertink jwoertink commented Jun 28, 2023

Closes #36
Fixes #38
Fixes #39

This PR does a few things:

  • Update the CI to remove the cron schedule. Github will disable it if there's no activity after a bit, and this shard isn't updated often enough to keep that going
  • Update LuckyFlow to the latest version and setup Webless. The specs no long need a chromedriver to run which allows them to run a lot faster with less dependencies
  • Updated the CI to include windows so we can start testing this against windows.
  • I set the min Crystal version to 1.4, though I imagine we need at least 1.6 or latest for all the Window stuff..

…bless. Updating the CI with all the new checks. Fixes #39 Fixes #38
@jwoertink
Copy link
Contributor Author

Looks like Flow still isn't Windows ready. Selenium has an issue open crystal-loot/selenium.cr#31 but I'd assume this shard will still work on Windows, just without being able to run specs....

@beta-ziliani
Copy link

Per crystal-lang/crystal#13131 the OS-independent way to kill a process is Process#terminate

@jwoertink
Copy link
Contributor Author

Yup! Already got a PR up on Selenium crystal-loot/selenium.cr#33 😄 I'll get that merged in, then get LuckyFlow updated, then update this shard and the yak will be clean shaven!

@jwoertink jwoertink merged commit d8c2844 into master Jul 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec failing Update github actions CI Windows Compilation Error
3 participants