Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives in @contract_interface #83

Closed
milancermak opened this issue Oct 11, 2022 · 1 comment · Fixed by #85
Closed

False positives in @contract_interface #83

milancermak opened this issue Oct 11, 2022 · 1 comment · Fixed by #85

Comments

@milancermak
Copy link

Consider this interface declaration (a simplified version of this one):

@contract_interface
namespace IModuleController {
    func set_write_access(module_id_doing_writing: felt, module_id_being_written_to: felt) {
    }
}

Amarna produces 2 false positives - unused argument (for both arguments) and function never called.

Screenshot 2022-10-11 at 21 15 42

Of course, neither make sense in a @contract_interface declaration.

@fcasal
Copy link
Collaborator

fcasal commented Oct 14, 2022

Thanks for reporting this, namespace decorators weren't being propagated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants