Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check namespace decorators for interfaces #85

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Check namespace decorators for interfaces #85

merged 2 commits into from
Oct 14, 2022

Conversation

fcasal
Copy link
Collaborator

@fcasal fcasal commented Oct 14, 2022

closes #83

milancermak
milancermak reviewed Oct 14, 2022
View reviewed changes
amarna/rules/gatherer_rules/DeclaredFunctionsGatherer.py Outdated
@@ -58,4 +62,5 @@ def code_element_function(self, tree: Tree) -> None:
assert function_name

func = FunctionType(function_name, getPosition(tree), self.fname, decorators)
print(func)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten debug print?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

@fcasal fcasal merged commit 391aeb3 into main Oct 14, 2022
@dguido dguido deleted the interface_namespace branch December 15, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancermak milancermak milancermak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives in @contract_interface
2 participants
@fcasal @milancermak