Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): file is optional #65

Merged
merged 4 commits into from
Aug 10, 2022
Merged

feat(cli): file is optional #65

merged 4 commits into from
Aug 10, 2022

Conversation

0xLucqs
Copy link
Contributor

@0xLucqs 0xLucqs commented Aug 4, 2022

Creating a new rule

  • Documented the code.
  • Added tests for the new rule in the amarna/tests/ folder.
  • Added the new rule description to the README file.

Pull request description
This PR allows to use amarna without specifying a file (ex: amarna --show-rules)

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

amarna/command_line.py Show resolved Hide resolved
@0xLucqs 0xLucqs requested a review from fcasal August 9, 2022 10:17
amarna/command_line.py Outdated Show resolved Hide resolved
amarna/command_line.py Outdated Show resolved Hide resolved
@0xLucqs 0xLucqs requested a review from fcasal August 10, 2022 08:39
Copy link
Collaborator

@fcasal fcasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also added the filename to the error message.

@fcasal fcasal merged commit be8b25d into crytic:main Aug 10, 2022
0xLucqs added a commit to 0xLucqs/amarna that referenced this pull request Sep 15, 2022
* File is optional and added missing checks

Co-authored-by: Filipe Casal <fcasal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants