Fix solc version detection for --solc-solcs-(select|bin) case #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the solc version is detected only once when starting, but this may cause a mismatch between the detected version and the compiler version that is then used. Move the version extraction to the _run_solc(...) function to avoid this problem. Also add support for passing an environment to get_version(...), this is required when using compilers managed with solc-select.
elopez
force-pushed
the
solc-version-detection
branch
from
d22bac1 to
dcc9bf7
Compare
|
This is a great catch, thanks @elopez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the solc version is detected only once when starting, but
this may cause a mismatch between the detected version and the
compiler version that is then used. Move the version extraction
to the _run_solc(...) function to avoid this problem. Also add
support for passing an environment to get_version(...), this is
required when using compilers managed with solc-select.