Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reentrancy-event to better support cross function risks #1482

Open
montyly opened this issue Nov 28, 2022 · 0 comments
Open

Improve reentrancy-event to better support cross function risks #1482

montyly opened this issue Nov 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@montyly
Copy link
Member

montyly commented Nov 28, 2022

With #1351, we removed a lot of FPs due to nonReentrant. However at the same time we removed TP for cross function reentrancy that can lead to have events in the incorrect order. See #1351 (comment).

We should improve the detector to catch these edge cases
@0xalpharush 0xalpharush added the enhancement New feature or request label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@montyly @0xalpharush