Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reentrancy detectors #1351

Merged
merged 11 commits into from
Nov 28, 2022
Merged

Improve reentrancy detectors #1351

merged 11 commits into from
Nov 28, 2022

Conversation

montyly
Copy link
Member

@montyly montyly commented Aug 17, 2022

I might also improve the reentrancy-event filtering to detect cross-functions reentrancy on event - through this is usually only informational and have a limited impact.

Additionally right now nonReentrant is only checked based on the modifier name. We could compare the source code hash of the known version to increase the confidence.

This require additional internal testing before being merged.

- Fix loop detection (fix #1019)
- Add python types
Fix type in function.reacheable_from_functions
- reentrancy-eth/reentrancy-no-eth: do not warn if the function is non reentrant, and there is no other reentrant function that writes to the affected variable
- reentrancy-event: do not warm if the function is non reentrant
@montyly
Copy link
Member Author

montyly commented Aug 17, 2022

TODO: replace is no other reentrant function that writes to the affected variable to include read, and state variable that are public.

This will help reviewing cross protocol reentrancies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant