Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inheritance-graph and call-graph don't use filenames #727

Closed
rmi7 opened this issue Dec 13, 2020 · 2 comments
Closed

inheritance-graph and call-graph don't use filenames #727

rmi7 opened this issue Dec 13, 2020 · 2 comments

Comments

@rmi7
Copy link
Contributor

rmi7 commented Dec 13, 2020

Both the inheritance-graph and call-graph printers will create a dot file which does not include the filename. inheritance-graph creates contracts.dot, call-graph creates all_contracts.dot. This is problematic when running these slither printers an multiple files during multiple runs, as the outputted dot files always have these same names.

The fix seems to be adding call-graph and inheritance-graph in the outputted filenames, as well as the name of the file, as in:
Filename.sol.call-graph.dot and Filename.sol.inheritance-graph.dot.

Let me know if you agree or have other ideas and I will create a PR.

@rmi7
Copy link
Contributor Author

rmi7 commented Dec 13, 2020

also see #726, which is kind of related

@rmi7 rmi7 changed the title inheritance-graph and call-graph use the same output filename inheritance-graph and call-graph don't use filenames Dec 13, 2020
@rmi7
Copy link
Contributor Author

rmi7 commented Dec 15, 2020

fixed in #729

@rmi7 rmi7 closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant