Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix set self.filename when using crytic-compile #726

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

rmi7
Copy link
Contributor

@rmi7 rmi7 commented Dec 13, 2020

When using CryticCompile (the "default"), self.filename will not be set, but is passed into each printer. Due to this, executing the inheritance-graph and call-graph printers will result in files with the default name, contracts and all_contracts, respectively. Instead of using the name of the Solidity file. Example on Migrations.sol:

INFO:Printers:Call Graph: all_contracts.dot
Call Graph: Migrations.dot

INFO:Printers:Inheritance Graph: contracts.dot

With the fix of this PR applied the result will instead be:

INFO:Printers:Call Graph: Migrations.sol.dot
Call Graph: Migrations.dot

INFO:Printers:Inheritance Graph: Migrations.sol.dot

@montyly montyly merged commit b617195 into dev Dec 15, 2020
@montyly montyly deleted the fix-selffilename-when-cryticcompile branch December 15, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants