Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AST parsing testing #1118

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Refactor AST parsing testing #1118

merged 2 commits into from
Mar 16, 2022

Conversation

montyly
Copy link
Member

@montyly montyly commented Mar 16, 2022

This PR refactor the AST parsing tests:

  • We will now have a list of tests, rather than iterating over the tests/ast_parsing directory. We will also stop relying on the filename to know the solc version. This will allow us more fine-grained control over the tests, and ease adding new tests.
  • The tests will now install automatically the missing solc version using solc-select
  • The tests will not run on new solc version until we update them - this will prevent the CI from failing on every new solc version

@montyly montyly merged commit 018d0df into dev Mar 16, 2022
@montyly montyly deleted the dev-refactor-ast-parsing branch March 16, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant