Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail with no results and sarif output #1229

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Do not fail with no results and sarif output #1229

merged 1 commit into from
Jun 17, 2022

Conversation

sveitser
Copy link
Contributor

@sveitser sveitser commented Jun 7, 2022

Close #1228

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sveitser sveitser changed the base branch from master to dev June 7, 2022 18:53
@0xalpharush 0xalpharush self-requested a review June 17, 2022 15:29
@montyly montyly merged commit 6a2e1e0 into crytic:dev Jun 17, 2022
@montyly
Copy link
Member

montyly commented Jun 17, 2022

Great catch, thanks @sveitser

@sveitser sveitser deleted the fix-sarif-empty-results branch June 17, 2022 16:03
@sveitser sveitser restored the fix-sarif-empty-results branch June 27, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xalpharush 0xalpharush 0xalpharush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slither fails with no detectors results and sarif output
4 participants
@sveitser @CLAassistant @montyly @0xalpharush