Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: upgrade from Ubuntu Bionic (18.04) to Focal (20.04) #1242

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Dockerfile: upgrade from Ubuntu Bionic (18.04) to Focal (20.04) #1242

merged 1 commit into from
Jul 26, 2022

Conversation

greenknot
Copy link
Contributor

It fixes the following Python error when running slither:

  AttributeError: module 'typing' has no attribute '_SpecialForm'

It fixes the following error when running slither:

  AttributeError: module 'typing' has no attribute '_SpecialForm'
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2022

CLA assistant check
All committers have signed the CLA.

@0xalpharush 0xalpharush requested a review from elopez July 7, 2022 17:50
Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution @greenknot!

note to self: if pysha3 gets removed soon, we very likely can remove gcc, python3-dev (and maybe some other apt packages?). It would be cool to replace the hardcoded solc 0.4.25 with solc-select too.

@montyly montyly changed the base branch from master to dev July 25, 2022 13:55
@montyly
Copy link
Member

montyly commented Jul 26, 2022

Thanks @greenknot

@montyly montyly merged commit c4c7d56 into crytic:dev Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants