implement detector for erc20 tokens that have function collision with…

[0xalpharush]

… DOMAIN_SEPARATOR

• Also implements solidity sig and return type for public/external state variables

Heuristic: warn if external or public function/ state variable name collides with hash of "DOMAIN_SEPARATOR()" or the return type is not bytes32
cc @transmissions11

[lgtm-com]

This pull request introduces 1 alert when merging f7e22a7 into 5a6b630 - view on LGTM.com

new alerts:

• 1 for Unused import

[transmissions11]

amazing thank you so much @0xalpharush!

[lgtm-com]

This pull request introduces 1 alert when merging 406f31b into 78397b9 - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com]

This pull request introduces 1 alert when merging 0d04e17 into 78397b9 - view on LGTM.com

new alerts:

• 1 for Unused import

[montyly]

In addition, we could:

• Look for collision with public state variables (in case someone creates a state variable name fopwCDKKK)
• And maybe check the return type of DOMAIN_SEPARATOR() (bytes32)

[lgtm-com]

This pull request introduces 1 alert when merging 0e264b3 into 719e4e9 - view on LGTM.com

new alerts:

• 1 for Unused import

[montyly]

Why overwrite the functions from variables? (

slither/slither/core/variables/variable.py

Lines 142 to 178 in d8e526e

	###################################################################################
	###################################################################################
	# region Signature
	###################################################################################
	###################################################################################
	@property
	def signature(self) -> Tuple[str, List[str], List[str]]:
	"""
	Return the signature of the state variable as a function signature
	:return: (str, list(str), list(str)), as (name, list parameters type, list return values type)
	"""
	# pylint: disable=import-outside-toplevel
	from slither.utils.type import (
	export_nested_types_from_variable,
	export_return_type_from_variable,
	)
	return (
	self.name,
	[str(x) for x in export_nested_types_from_variable(self)],
	[str(x) for x in export_return_type_from_variable(self)],
	)
	@property
	def signature_str(self) -> str:
	"""
	Return the signature of the state variable as a function signature
	:return: str: func_name(type1,type2) returns(type3)
	"""
	name, parameters, returnVars = self.signature
	return name + "(" + ",".join(parameters) + ") returns(" + ",".join(returnVars) + ")"
	@property
	def solidity_signature(self) -> str:
	name, parameters, _ = self.signature
	return f'{name}({",".join(parameters)})'

)

I am also not sure about returning str(self.type) in signature, and None for non-public variable

[lgtm-com]

This pull request introduces 1 alert when merging 07964f9 into 7009c33 - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com]

This pull request introduces 1 alert when merging 4301171 into 7009c33 - view on LGTM.com

new alerts:

• 1 for Unused import