add _disableInitializers() detection #1344
Conversation
|
Is there a reason you check all internal calls instead of just the contract's constructor? EDIT: Oh nvm, this is only checking the constructor and not all functions already... Would you mind adding test cases here and generating the output using |
|
I was looking at the function object and |
| for f in functions: | ||
| for m in f.modifiers: | ||
| if m.name == "initializer": | ||
| return True | ||
| # filtering out SolidityFunction from the internal calls as we don't need to match against those names | ||
| internal_func_calls = [c for c in f.all_internal_calls() if not isinstance(c, SolidityFunction)] |
There was a problem hiding this comment.
This loops over the list twice. I think it'd be better to remove the list comprehension and iterate once over f.all_internal_calls()
|
Can you run pylint and black? You can obtain the correct versions by running |
Co-authored-by: alpharush <0xalpharush@protonmail.com>
|
Installing |
|
Tests + coverage came out good 👍️ |
|
This is great, thanks @plotchy |
Enhance
unprotected_upgradeabledetector to remove_disableInitializers()false positive.Related to #1236