Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include shadowed state variables in contract's state_variables property #1432

Closed
wants to merge 2 commits into from
Closed

fix: include shadowed state variables in contract's state_variables property #1432

wants to merge 2 commits into from

Conversation

0xalpharush
Copy link
Contributor

fixes #1322

@montyly
Copy link
Member

montyly commented Oct 26, 2022

I am a bit unsure about adding an API breaking change here. I believe that #1332 can be fixed by using state_variables_ordered. So I would rather keep the current behavior and maybe document better state_variables and mention that this does not return shadowed variables - which are not accessible from the contract's perspective

@0xalpharush 0xalpharush marked this pull request as draft October 26, 2022 13:48
@0xalpharush
Copy link
Contributor Author

0xalpharush commented Oct 26, 2022 •
edited
Loading

I am a bit unsure about adding an API breaking change here. I believe that #1332 can be fixed by using state_variables_ordered. So I would rather keep the current behavior and maybe document better state_variables and mention that this does not return shadowed variables - which are not accessible from the contract's perspective

Okay, I replaced this PR with #1444 and will update the docs later

@0xalpharush 0xalpharush closed this Jan 3, 2023
@montyly montyly deleted the fix-shadowed-vars-read-storage branch January 13, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elopez elopez Awaiting requested review from elopez elopez will be requested when the pull request is marked ready for review elopez is a code owner

@montyly montyly Awaiting requested review from montyly montyly will be requested when the pull request is marked ready for review montyly is a code owner

@smonicas smonicas Awaiting requested review from smonicas smonicas will be requested when the pull request is marked ready for review smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xalpharush @montyly