replace decode/encode_single with decode/encode | formatting #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decode/encode_single was removed from eth-abi: ethereum/eth-abi@b037171 move eth stuff out from the try, since no matter the error, it throws pip3 install web3 for everything
|
|
|
I think it would be best to add web3.py as a dependency to slither-read-storage and entirely remove the try-except import #1433. We may want to pin the version so that people can use python 3.11 ethereum/web3.py#2699 |
|
Replaced by #1743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode/encode_single was removed from eth-abi, so this change replaces it with the regular decode/encode func.
ethereum/eth-abi@b037171
move eth stuff out from the try-except, since no matter the error, it throws pip3 install web3 for everything