-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ck printer #1895
feat: ck printer #1895
Conversation
Co-authored-by: alpharush <0xalpharush@protonmail.com>
slither/utils/upgradeability.py
Outdated
@@ -489,6 +489,63 @@ def encode_ir_for_compare(ir: Operation) -> str: | |||
return "" | |||
|
|||
|
|||
# pylint: disable=too-many-branches | |||
def encode_ir_for_halstead(ir: Operation) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MMh I think we should move this outside of utils/upgradeability
slither/printers/summary/ck.py
Outdated
|
||
WIKI = "https://github.com/trailofbits/slither/wiki/Printer-documentation#ck" | ||
|
||
def output(self, _filename): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the return types for all the functions? (use -> None
if the function returns nothing)
NOTE: This pr is based on the
martin-printer
branch. That pr should be merged first.DESCRIPTION:
OPEN QUESTION: