Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bytes pop ir #1926

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix bytes pop ir #1926

merged 1 commit into from
Jun 8, 2023

Conversation

smonicas
Copy link
Contributor

Popping from bytes should give a bytes1 type not bytes #1904 (comment)

@smonicas smonicas requested a review from montyly as a code owner May 18, 2023 07:45
@0xalpharush
Copy link
Contributor

Let's add a test

@0xalpharush
Copy link
Contributor

I'm wondering if we should consider bytes an ArrayType and with type bytes1

@0xalpharush 0xalpharush merged commit d0f12dc into dev Jun 8, 2023
@0xalpharush 0xalpharush deleted the fix-bytes-pop-ir branch June 8, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly montyly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smonicas @0xalpharush