feat: add --unstructured to slither-read-storage; retrieve custom storage layouts
#1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `coerce_type(solidity_type, value)`
i.e., all constant bytes32 variables
before calling `get_storage_layout`
using slither-read-storage
check function return type sizes, and add comments in `find_constant_slot_storage_type`
instead of string casting
and `test_unstructured_storage` by moving them into individual files in tests/fixtures/ and importing them into conftest.py
…ge-unstructured # Conflicts: # slither/tools/read_storage/read_storage.py # tests/test_read_storage.py
Now that the fixtures are stand-alone modules, Web3 is no longer used here other than web3.Contract
Co-authored-by: alpharush <0xalpharush@protonmail.com>
instead of separate files
in `find_hardcoded_slot_in_fallback`
so it is only used when `--unstructured` is set or when we set `self.unstructured = True`
without assuming the loaded type is an address
…ge-unstructured # Conflicts: # tests/conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1752