Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in Contract.get_state_variable_from_canonical_name() #1983

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix typo in Contract.get_state_variable_from_canonical_name() #1983

merged 1 commit into from
Aug 3, 2023

Conversation

njusunyi
Copy link
Contributor

The function should compare v.canonical_name with the parameter. Currently, it works the same as get_state_variable_from_name()

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@njusunyi njusunyi changed the title fix typo in state.get_state_variable_from_canonical_name() fix typo in Contract.get_state_variable_from_canonical_name() Jun 22, 2023
@0xalpharush 0xalpharush changed the base branch from master to dev July 24, 2023 02:43
@0xalpharush 0xalpharush merged commit 3f90e86 into crytic:dev Aug 3, 2023
@0xalpharush
Copy link
Contributor

Thanks @yisun92!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njusunyi @CLAassistant @0xalpharush