Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add new docs link #2010

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Conversation

sambacha
Copy link
Contributor

@sambacha sambacha commented Jun 29, 2023

Fix the status badges and include a link to the documentation page that is now generated

Edit:
Additional changes include a direct link to the wiki
updated slack badge to join
more information in the citation.cff file
slight style changes regarding the markup of the header

Fix the status badges and include a link to the documentation page that is now generated
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2023

CLA assistant check
All committers have signed the CLA.

This creates a `CITATION.cff` file. The information is taken from arXiv's bibtex for the whitepaper:

```bibtex
@inproceedings{Feist_2019, doi = {10.1109/wetseb.2019.00008}, url = {https://doi.org/10.1109%2Fwetseb.2019.00008}, year = 2019, month = {may}, publisher = {{IEEE} }, author = {Josselin Feist and Gustavo Grieco and Alex Groce}, title = {Slither: A Static Analysis Framework for Smart Contracts}, booktitle = {2019 {IEEE}/{ACM} 2nd International Workshop on Emerging Trends in Software Engineering for Blockchain ({WETSEB})} }
```
@sambacha
Copy link
Contributor Author

Citation example in the GitHub UI

Screenshot 2023-06-29 at 3 58 49 AM

Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sambacha! I left a few suggestions below

CITATION.cff Outdated
- given-names: Gustavo
family-names: Grieco
- given-names: Alex
family-names: Grace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
family-names: Grace
family-names: Groce

CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
sambacha added 2 commits June 29, 2023 13:31
fixed slack badge
added wiki badge
updated pypi badge
corrected spelling mistakes
took abstract from paper and added it into the description

note: AGPL-3.0-only is lower case as the citation.cff validator said so. [I used this https://citation-file-format.github.io/cff-initializer-javascript/#/finish](https://citation-file-format.github.io/cff-initializer-javascript/#/finish)
@sambacha
Copy link
Contributor Author

Not sure what the subheading under the slack badge should say, just left a generic statement there.

Also I just joined, had to make sure the invite works :)

@0xalpharush 0xalpharush changed the base branch from master to dev July 6, 2023 14:50
@0xalpharush 0xalpharush changed the base branch from dev to master July 6, 2023 14:51
@0xalpharush 0xalpharush merged commit f3be9ef into crytic:master Jul 6, 2023
@0xalpharush
Copy link
Contributor

Thanks @sambacha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants