Allow underscore in variable naming convention for internal state variables #2110
Conversation
…e variables and update test_detector tests snapshot
dokzai
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
|
| @@ -53,6 +53,7 @@ contract Test { | |||
|
|
|||
| contract T { | |||
| uint private _myPrivateVar; | |||
| uint internal _myInternalVar; | |||
| uint _myPublicVar; | |||
There was a problem hiding this comment.
| uint _myPublicVar; | |
| uint public _myPublicVar; |
There was a problem hiding this comment.
Would you make all of the _myPublicVar's public and run python tests/e2e/detectors/test_detectors.py --compile to update the compiled artifacts please? You'll also want to run pytest tests/e2e/detectors/test_detectors.py --insta update to update the snapshots as the public variable should be included in the snapshot after updating the solidity code.
There was a problem hiding this comment.
Thanks!
I updated the variable to public and updated the snapshots accordingly.
| @@ -53,6 +53,7 @@ contract Test { | |||
|
|
|||
| contract T { | |||
| uint private _myPrivateVar; | |||
| uint internal _myInternalVar; | |||
| uint _myPublicVar; | |||
There was a problem hiding this comment.
Would you make all of the _myPublicVar's public and run python tests/e2e/detectors/test_detectors.py --compile to update the compiled artifacts please? You'll also want to run pytest tests/e2e/detectors/test_detectors.py --insta update to update the snapshots as the public variable should be included in the snapshot after updating the solidity code.
|
@dokzai 🫡 |
Hello!
This is my attempt at addressing #1034 based on the recommendation provided in the thread.
Thanks!