Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to add a new Detector that finds patterns of literal values in numbers that are too big for humans to safely manage, issue a warning, and advise to use the proper denominations of Ether. For example:
uint x = 0x0000000000001;
uint y = 1000000000000000000;
balance += x + y + 1000000;
would be detected as too big but 100 wei or 1000 szabo would not. My limit so far is anything with more than “00000” (5 zeros) should use another denomination of Ether.
I received help from Josselin Feist and heavily use his code example.