Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: docker improvement #244

Merged
merged 1 commit into from
Nov 6, 2019
Merged

feat: docker improvement #244

merged 1 commit into from
Nov 6, 2019

Conversation

yxliang01
Copy link
Contributor

  • install and run as normal user
  • copy code from current directory, instead of installing from registry (might not be wanted?)
  • add .dockerignore file, only ignores Dockerfile currently

@yxliang01
build.docker: install and run as normal user, copy code from current …
b22799c 
…directory, add .dockerignore file

.dockerignore only ignores Dockerfile currently
@CLAassistant
Copy link

CLAassistant commented May 14, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yxliang01
Copy link
Contributor Author

yxliang01 commented Oct 26, 2019 •
edited
Loading

@montyly I finally remember to come back here and signed the CLA. Is this still relevant or wanted? If not, I can change accordingly or close this. :)

@yxliang01
Copy link
Contributor Author

@montyly Possibly you want to process this as well? Since this has been hanging for long 6 months. For some reason the CLA status is not so right?..

@montyly
Copy link
Member

montyly commented Nov 6, 2019

Hi @yxliang01.
I am not sure why, but something is wrong with the CLA and I can't merge the PR. Would it be ok for you to close this PR and create a similar one? Thanks!

@yxliang01 yxliang01 closed this Nov 6, 2019
@yxliang01 yxliang01 reopened this Nov 6, 2019
@yxliang01
Copy link
Contributor Author

@montyly The CLA is working now after closing and reopening. So, just need to wait for the CI :)

@yxliang01
Copy link
Contributor Author

@montyly 🎉 CI passed :)

@montyly
Copy link
Member

montyly commented Nov 6, 2019

Awesome, thank you @yxliang01 !

@montyly montyly merged commit b6f8231 into crytic:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yxliang01 @CLAassistant @montyly