Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore naming convention restriction on echidna_ and crytic_ functions #317

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

agroce
Copy link
Contributor

@agroce agroce commented Aug 20, 2019

Addresses #316

@agroce agroce requested a review from montyly August 20, 2019 17:24
@agroce agroce self-assigned this Aug 20, 2019
@@ -97,6 +98,8 @@ def _detect(self):
if not self.is_mixed_case(func.name):
if func.visibility in ['internal', 'private'] and self.is_mixed_case_with_underscore(func.name):
continue
if (func.name.find("echidna_") == 0) or (func.name.find("crytic_") == 0):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be find or startswith ?

They are unlikely to have collision, but we probably want to enforce the properties to start with these patterns, rather than at arbitrary place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I simply was unaware of startswith as an alternative to find == 0. Fixing

@montyly montyly merged commit 9922eb4 into master Aug 21, 2019
@montyly montyly deleted the special_case_echidna_properties branch August 21, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants