Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique ID per finding #367

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Add unique ID per finding #367

merged 3 commits into from
Nov 12, 2019

Conversation

montyly
Copy link
Member

@montyly montyly commented Nov 12, 2019

Add a unique ID per finding.

The ID is based on the finding's description. It is not sensible to the contract/function/variable source mapping. The ID is sensible to the node/expression source mapping (otherwise we risk collisions).

If we end up supporting contracts with similar names, the ID schema will need to be changed, otherwise, we risk collisions.

Replace #335

@montyly montyly mentioned this pull request Nov 12, 2019
@montyly montyly merged commit 29cd6dc into dev Nov 12, 2019
@montyly montyly deleted the dev-id branch November 12, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant