-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echidna printer: improve constant function detection #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect compiler version access
Remove dupplicate constant values
- Add types to constant - Convert the type in case of explicit type conversion (ex: address(0x41))
- Add constructors info - Add impacts/is_impacted_by info
In addition, this PR adds:
"constants_used": {
"Ownable": {
"transferOwnership(address)": [
[
{
"value": 0,
"type": "address"
}
]
]
},
"constructors": {
"Ownable": "Ownable()",
"BasicToken": "Ownable()",
"approve(address,uint256)": {
"impacts": [
"transferFrom(address,address,uint256)",
"approve(address,uint256)",
"allowance(address,address)"
],
"is_impacted_by": [
"transferFrom(address,address,uint256)",
"approve(address,uint256)",
]
}, |
ggrieco-tob
approved these changes
Apr 14, 2020
I added two additional info:
Example: contract C{
function test() public;
}
contract D{
C c;
function f() public{
c.test();
}
function f2(address addr) public{
C(addr).test();
}
} Will give
Note: |
Added:
contract C{
function test() public{
address(this).balance;
}
}
Given the number of new features of this printer, the json must be documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heuristic:
https://solidity.readthedocs.io/en/v0.5.0/contracts.html?highlight=pure#view-functions