Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all for loop tests #655

Merged
merged 8 commits into from
Nov 10, 2020
Merged

fix all for loop tests #655

merged 8 commits into from
Nov 10, 2020

Conversation

samczsun
Copy link
Contributor

@samczsun samczsun commented Oct 3, 2020

had to update the expected outputs for the compact ast cfg because we were generating them wrong. here's an example:

code:

    function loopNoPreCond() public {
        uint c;

        uint i = 0;
        for (; ; i++) {
            if (i >= 10) break;
            c++;
        }
    }

dev:
for_0 6 0_compact_C_loopNoPreCond()_expected dot

this branch:
for_0 6 0_compact_C_loopNoPreCond()_actual dot

notice the incorrect edge from 9->4 on dev, which is fixed on this branch

@samczsun samczsun requested a review from montyly October 3, 2020 23:01
@lgtm-com
Copy link

lgtm-com bot commented Oct 3, 2020

This pull request introduces 1 alert when merging 6d4e1c7 into 6aee221 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@montyly montyly merged commit cf65a10 into dev Nov 10, 2020
@montyly montyly deleted the bugfix/for branch December 4, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants