Add the support for multiple compilation units. #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lot of breaking changes: - SlitherCore is split into SlitherCore and SlitherCompilationUnit, as a result several functions from Slither are not direclty accessible anymore - There is a list of compilation unit in SlitherCore - The detectors are run per compilation unit - however slither filters out results if their ID are the same to avoid dupplicate - The printers are run per SlitherCore. - The non-crytic-compile inputs are removed (json/list of json). This will help us to clean the API in the long run. These were only used in internal tests - slither.get_contract_from_name returns now a list (which can be empty)
|
This pull request fixes 1 alert when merging 73764ed into cf07c59 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 71e33c6 into cf07c59 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 84f7605 into cf07c59 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 6233f31 into cf07c59 - view on LGTM.com fixed alerts:
|
This was referenced Apr 22, 2021
Closed
|
This pull request fixes 1 alert when merging 9533947 into 4a8cdf7 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging ceb7478 into 4a8cdf7 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 3f3855a into 4a8cdf7 - view on LGTM.com fixed alerts:
|
This was referenced Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a lot of breaking changes:
anymore
There are a couple of open questions left. For it's difficult to know what a compilation unit refers too, so for the tool that ask for a contract name (ex:
slither-flat), and the contract is shared by multiple compilation unit, it is unclear what to do