-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for ranged compiler versions for install flag #85
Open
dev1644
wants to merge
13
commits into
dev
Choose a base branch
from
feature/install-multiple-compilers-from-range
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#96) A single version string was passed to install_artifacts instead of a version list. This caused install_artifacts to install other versions contained in the requested version (e.g. 0.4.2 was installed as well when 0.4.25 was requested). Call the installation function with a list as intended, so that the correct version and that version only is installed now. Test case: * `rm ~/.solc-select -rf` * `solc-select use 0.4.25 --always-install` Fixes: #95
* Add a `pip-audit` workflow * Fixing stale python CI version by dropping specific version * Wrap version in quotes * Unify python versions * Bumping setup and python versions for mac * Bypass setuptools for installation Co-authored-by: Natalie Chin <natalie.chin@trailofbits.com>
#107) * Update workflows to test 3.7-3.11 python versions * Run pip install . instead of setuptools
Nat Chin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66