Changed formatted strings to fstrings in add_collaborators.py #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzussman
requested changes
Nov 4, 2022
| opt.warn('Aborting') | ||
| return | ||
|
|
||
| opt.info('Proceeding to add {} as collaborators to {} with {} permissions' | ||
| .format(opt.users.name, repo_full_name, opt.permission)) | ||
| opt.info(f'Proceeding to add {opt.users.name} as collaborators to {repo_full_name} with {opt.permission} permissions' |
Comment on lines
+186
to
+188
| + f'Boatswain configuration ({config_path}). Please add this information ' | ||
| + 'to your config file under section [canvas] with key "token".' | ||
| + '\n'.format(config_path)) | ||
| + '\n') |
There was a problem hiding this comment.
This doesn't need the + - Python strings are implicitly concatenated
There was a problem hiding this comment.
Same for the rest of the changes in this file
| else: | ||
| promptf = prompt | ||
|
|
||
| promptf = '{}: '.format(promptf) | ||
| promptf = '{promptf}: ' |
| 'for users in {} under org {} with name {}') | ||
| .format(opt.groups.name, opt.org, | ||
| fmt_hyphen(opt.prefix, '<group>')), | ||
| f'for users in {opt.groups.name} under org {opt.org} with name {fmt_hyphen(opt.prefix, '<group>')}'), |
There was a problem hiding this comment.
I would split this into multiple lines. Also, I'm not sure the quotes surrounding '<group>' are going to work. Quotes in the format part of f-strings can get tricky - I would test that and see if it potentially works with double quotes. The cleanest solution may just be to turn the fmt_hyphen section into a variable and use that instead
|
Also, if you could edit the name of the PR to match the rest of the changes made that would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the formatted strings in add_collaborators to fstrings