Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocis bumped. the expected failures removed. #4773

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

2403905
Copy link

@2403905 2403905 commented Jul 22, 2024

No description provided.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@phil-davis phil-davis merged commit 30a7913 into cs3org:edge Jul 22, 2024
8 of 10 checks passed
@kobergj
Copy link
Contributor

kobergj commented Jul 22, 2024

Please don't merge red PRs. The changelog pipeline was failing, which is not acceptable. The only step which is allowed to be red is the license step.

We had to fix it on our feature branch: #4774

@phil-davis
Copy link
Contributor

Please don't merge red PRs.

Sorry, I saw that the drone CI had passed, and I knew that "other stuff is known to fail" and didn't look closely. I will be more careful in future.

(this is a problem with having "known red" in CI - is there something that we can do to fix that? Or maybe we should remove the License Compliance workflow, if we are ignoring it anyway)

@kobergj
Copy link
Contributor

kobergj commented Jul 22, 2024

(this is a problem with having "known red" in CI - is there something that we can do to fix that? Or maybe we should remove the License Compliance workflow, if we are ignoring it anyway)

I 100% agree. But as far as I know we cannot remove this step.

@micbar is there any chance we can disable this step? Accepted red pipelines are bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants