Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed Buffer constructor deprecation #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed Buffer constructor deprecation #42

wants to merge 1 commit into from

Conversation

dehmer
Copy link

@dehmer dehmer commented Mar 25, 2021

Quick PR replacing deprecated Buffer constructor with Buffer.alloc() in binary writer.
All 1369 test are passing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 226d988 on dehmer:buffer-deprecation into b85b7b9 on cschwarz:master.

@dehmer dehmer mentioned this pull request Mar 25, 2021
Open
@hoetmaaiers
Copy link

Can this be merged into the published npm package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dehmer @coveralls @hoetmaaiers