Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[FEATURE] <A question submission box> (styling) #127

Closed
ykdojo opened this issue Aug 24, 2022 · 9 comments · Fixed by #131
Closed

[FEATURE] <A question submission box> (styling) #127

ykdojo opened this issue Aug 24, 2022 · 9 comments · Fixed by #131
Assignees

Comments

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 24, 2022

Description

As I recently asked on Tailwind UI's discord, I have a styling issue for #59 with this Tailwind UI component.

image

@ykdojo ykdojo added this to defaang Aug 24, 2022
@ykdojo ykdojo moved this to To do in defaang Aug 24, 2022
@ykdojo ykdojo moved this from To do to In progress in defaang Aug 24, 2022
@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 24, 2022

Note: looks like these two commits fixed almost everything except for a few minor font differences:

384436e
9d1d8cd

@ykdojo ykdojo self-assigned this Aug 25, 2022
@ykdojo ykdojo moved this from In progress to In review in defaang Aug 25, 2022
@subhoghoshX
Copy link
Collaborator

subhoghoshX commented Aug 25, 2022

Note: looks like these two commits fixed almost everything except for a few minor font differences:

384436e 9d1d8cd

Yes, you have to install the @tailwindcss/forms plugin if the component includes form elements.

Could you please elaborate on what font differences you're experiencing?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 25, 2022

It's not a huge deal, but the font looks slightly different:

image

@subhoghoshX
Copy link
Collaborator

The font-family looks the same. I think the font weight and the color are a little different.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 25, 2022

the fonts look slightly different, though?
image
image

@subhoghoshX
Copy link
Collaborator

the fonts look slightly different, though? image image

Oh no, that's an entirely different font-family. Let me dig into it.

@subhoghoshX
Copy link
Collaborator

I ended up asking Adam Wathan, the creator of TailwindCSS.

image

Essentially we need to add this:

html {
    font-feature-settings: 'cv03','cv04','cv11';
}

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 25, 2022

cool!

so we just need to add that in global css right?

@ykdojo ykdojo moved this from In review to To do in defaang Aug 26, 2022
@subhoghoshX
Copy link
Collaborator

Yes. I think the base layer in TailwindCSS would be an appropriate place to add it.

Let me send a PR.

Repository owner moved this from To do to Done in defaang Aug 26, 2022
@subhoghoshX subhoghoshX moved this to Done in defaang Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants