Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

feat: made the submission box (front-end only for now) #126

Merged
merged 6 commits into from
Aug 26, 2022

Conversation

ykdojo
Copy link
Collaborator

@ykdojo ykdojo commented Aug 24, 2022

screenshot:

image

closes #59 and #127

@vercel
Copy link

vercel bot commented Aug 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 5:53PM (UTC)

- Created the submission box
- Changed the site's background color to grey
@ykdojo ykdojo changed the title feat: started working on the submission box feat: made the submission box (front-end only for now) Aug 25, 2022
@ykdojo ykdojo marked this pull request as ready for review August 25, 2022 03:05
@RakeshSangem
Copy link

In order to filter the data/questions in the future, why don't we use tags for questions(arrays, binary trees etc.) ?

__
sema-logo  Summary: ❓ I have a question

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 25, 2022

I'd rather keep it simple and not implement tags for now. Maybe later

@subhoghoshX
Copy link
Collaborator

Looks good, thank you. I'm not sure about importing all those static fonts. But it's nothing critical I guess, we can optimize later.

I think making the form fields full width and applying some padding on the parent container, might make it look better. Something like below (Open to discuss though). And also a little bit of rounded corner hehe.

image

@subhoghoshX
Copy link
Collaborator

Also if I remember correctly, we were supposed to have a separate question and question description field. Looks like you merged it into one.

And also a question category and job title field.

@RakeshSangem
Copy link

Also if I remember correctly, we were supposed to have a separate question and question description field. Looks like you merged it into one.

And also a question category and job title field.

yes, title and description should be there!

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 25, 2022

Added position and question fields:

image

For styling, I think we can make it a separate issue/PR? @subhoghoshX

@subhoghoshX
Copy link
Collaborator

Sure that'd be better. I think we can merge it then.

@ykdojo ykdojo merged commit 4c3e290 into main Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] <A question submission box> (frontend)
3 participants