-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove <4
Python version constraint
#267
Conversation
a41e6cb
to
3a3e631
Compare
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 4 4
Lines 597 597
=======================================
Hits 570 570
Misses 27 27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for being late with the review, thanks your contribution!
@@ -0,0 +1,4 @@ | |||
--- | |||
fixes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove this yaml file from your MR? I think removing python <4 constraint should not be visible to any users, or it should not cause any functionality change and I include only those to the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Done: 0ccebbd
No worries, thanks for reviewing! |
Closes #266